Add recursion limit to FFI safety lint #130598
Open
+58
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
clubby789
requested changes
Sep 20, 2024
Fixes stack overflow in the case of recursive types
gurry
force-pushed
the
130310-improper-types-stack-overflow
branch
from
1a4286d
to
8ea1a53
Compare
compiler-errors
requested changes
Sep 20, 2024
| @@ -1658,6 +1670,9 @@ impl<'a, 'tcx> ImproperCTypesVisitor<'a, 'tcx> { | |||
| FfiResult::FfiUnsafe { ty, reason, help } => { | |||
| self.emit_ffi_unsafe_type_lint(ty, sp, reason, help); | |||
| } | |||
| FfiResult::RecursionLimitReached => { | |||
| self.cx.tcx.dcx().emit_err(RecursionLimitReached { ty, span: sp }); | |||
There was a problem hiding this comment.
This shouldn't be a recursion limit error. It should probably be under the same FFI-unsafety warning but with adjusted wording like "couldn't determine if infinitely recursive type is FFI safe"
There was a problem hiding this comment.
I wasn't myself sure whether to go with the warning or the error. Let me change it to a warning then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130310
Now we check against
tcx.recursion_limit()and raise an error if it the limit is reached instead of overflowing the stack.